This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: setup.exe rebase patch




Robert Collins wrote:


>>I also have a stand-alone rebase.exe that I would like to contribute
>>
> to
> 
>>Cygwin so that users can rebase without having to run setup.exe.
>>
> 
> Neato. This sounds like a cygutils thingo to me, or a new package.
> Chuck? Ohhhh Chuck?


Ummm...do we really want to fork the code into two separate locations? 
It seems to me that the best thing to do would be the following:

winsup/cinstall/Makefile.am:
bin_PROGRAMS: setup rebase
setup_SOURCES: ..... rebase.cc rebase.l rebase.y rebase.h .....
rebase_SOURCES: rebase.cc rebase.l rebase.y rebase.h
rebase_CFLAGS: -dREBASE_STANDALONE

in rebase.cc:

#if REBASE_STANDALONE
int main(int argc, char * argv[]) {
...
}
#endif

This way, the SAME code is used by both the standalone rebase.exe and 
setup.exe.  Otherwise, we'll continually have synchronization problems 
between the two (e.g. what if the format of /etc/rebase.conf changes?)


> One important thing is to have setup's rebasing and the rebase
> commandline tool *both* store their work in rebase.conf. That way they
> won't require full rebasing when someone fiddles with something.
> 

Yeah -- which is why they should both come from the same code.  In the 
same location.  I *strongly* advocate adding rebase.exe to the cinstall 
directory since it will be so tightly tied to setup.exe's behavior...

--Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]