This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH suggestion] aclocal wrapper script loops forever if automake-devel or automake-stable is missing


Pavel Tsekov wrote:

> Hey, there! :)
> 
> Does the attached patch make any sense ? It prevents an infinite loop
> if either automake-devel or automake-stable is missing.
> 

Yes, it does -- of course, setup enforces that automake depends on 
automake-devel and automake-stable, so if you see this error it's 
because you've overridden setup.exe...

Or you set the AUTO_STABLE / AUTO_DEVEL environment variables (incorrectly).

I've incorporated your suggestions into the next version of the 
wrappers.  However, as a general note, there are a few problems with 
your submission:

1) you patched a generated file, not a source file (aclocal is created 
from aclocal.in in the automake -src package).

2) you only patched one of the files -- but all scripts exhibit this 
behavior.  You'd actually need to provide similar patches for

automake:
   aclocal.in
   automake.in
autoconf:
   autoconf.in
   autoupdate.in
   autoreconf.in
   autoheader.in
   autoscan.in
   ifnames.in
libtool:
   libtool.in
   libtoolize.in

3) No ChangeLog entry

I have done all of the above, so no worries this time.  However, next 
time...

--Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]