This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3
Igor Pechtchanski wrote:
> On 25 Mar 2003, Robert Collins wrote:
>
>> + for (i = packages.begin (); i != packages.end (); ++i)
>> + {
>> + packagemeta & pkg = **i;
>> + for_each (pkg.installed.scripts().begin(),
>> pkg.installed.scripts().end(), + RunScript(pkg.name,
>> pkg.installed.scripts().size())); + ++k;
>> + Progress.SetBar2 (k, numpkg);
>> + }
>>
>> I was thinking that this would be part of RunScript - you've taken the
>> innermost aspect of it's operation.. I was thinking it would be a little
>> bit more encompassing - thus the run method.
>>
>> Hmm, I'm not sure that this can be done cleanly just now though, so...
>
> Yes, doing so would have required tacking on a dummy packagemeta onto the
> end of the list. Then RunScript would have traversed the list of
> packagemeta pointers... Either that, or yet another helper class that
> would store a package name and a pointer to a vector of Scripts...
> Either way, I didn't think it was worth the trouble.
>
>> Max, can you please check this in?
Done.
Igor: One very, very, very minor point - please put *2* spaces between your
name and email address in ChangeLogs.
Thanks,
Max.