This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Curious code in Installer::installOneSource
- From: "Max Bowsher" <maxb at ukf dot net>
- To: <cygwin-apps at cygwin dot com>
- Date: Sat, 5 Apr 2003 23:38:55 +0100
- Subject: Curious code in Installer::installOneSource
I'm working in this area to implement the MD5-on-install feature. Is there
any reason why I should not simplify this:
char msg[64];
strcpy (msg, "Installing");
Progress.SetText1 (msg);
log (LOG_PLAIN, String (msg) + " " + source.Cached ());
To this:
char msg[] = "Installing";
Progress.SetText1 (msg);
log (LOG_PLAIN, String (msg) + " " + source.Cached ());
Or even, this:
Progress.SetText1 ("Installing");
log (LOG_PLAIN, String ("Installing ") + source.Cached ());
(There is no other use of the msg variable outside the context shown here.)
Max.