This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: a2ps download site


David,

Looks much better now.
A few more nits:
- The patch still has CRLF line endings.
- The .tar.gz file extracted from the source archive has executable bits set.
- Why does the "all" step in the script perform the "spkg" and "pkg"
steps?  They are not needed for the build.  Neither is "finish", for that
matter.  (That may be an artifact of the build script, if so, ignore this).
- Is there a particular reason why the build is performed in-place, rather
than in a .build directory (which is created, BTW)?

Other than that, all seems to be ok.  The build seems to work.  As I said,
I haven't tested the binaries, but I assume you did and they work.  The
patch now contains only the Cygwin-specific README and the setup.hint, so
it's basically an OOTB build, anyway.

So, once the package is deemed ready, we wait until you accumulate the
necessary votes (I think you have already), and someone with access will
upload your package to the mirror.  It might be a good idea for you to
include the URLs of 3 files in the follow-up message: the binary and
source package tarballs and setup.hint, so that they're all in one place.
	Igor

On Tue, 15 Apr 2003 David_Hudson at capgroup dot com wrote:

> Hi Igor,
>
> Thanks for the feedback on this. It turns out my build script was messed
> up and I uploaded a bad source package. I fixed it and uploaded the
> fixed packages at.
>
> http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1.tar.bz2
> http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1-src.tar.bz2
>
> Once all the kinks of the packages have been worked out, what are the next
> steps to get the package into the distribution?
>
> Thanks
> Dave
>
>  David Hudson | The Capital Group Companies
>      | Location: BRO | Extension: 51887
>       Outside: 714-672-1887 | E-mail:
>              dyyh at capgroup dot com
>     [ Mailing: 135 S State College Blvd.
>          Brea, CA 92821-5704 USA ]
>
> Igor Pechtchanski <pechtcha at cs dot nyu dot edu>   To: David Hudson/INV/CG/CAPITAL at CG
> Sent by: cygwin-apps-owner at cygwin dot com     cc: cygwin-apps at cygwin dot com
> Subject: Re: a2ps download site
> 04/15/2003 08:16 AM
> Please respond to cygwin-apps
>
> Oops, forgot to address the "configure" comment:
>
> I never said you shouldn't include it, I just commented on the fact that
> there was one in the original distribution (and that, consequently, you
> should do whatever is normally done in that case).
>
> I was more concerned about files like "Makefile", which *aren't* present
> in the original distribution, but are in your patch.
>            Igor
>
> On Tue, 15 Apr 2003, Igor Pechtchanski wrote:
>
> > David,
> >
> > $ wget -C off http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1-src.tar.bz2
> > --11:05:42-- http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1-src.tar.bz2
> >            => `a2ps-4.12-1-src.tar.bz2'
> > Resolving mysite.verizon.net... done.
> > Connecting to mysite.verizon.net[206.46.189.90]:80... connected.
> > HTTP request sent, awaiting response... 200 OK
> > Length: 1,951,010 [application/x-tar]
> >
> > 100%[====================================>] 1,951,010    263.60K/s    ETA 00:00
> >
> > 11:05:52 (263.60 KB/s) - `a2ps-4.12-1-src.tar.bz2' saved [1951010/1951010]
> > $ tar tjvf a2ps-4.12-1-src.tar.bz2
> > -rw-rw-rw- DYYH/mkpasswd  810919 2003-04-14 14:47:04 a2ps-4.12-1.patch
> > -rwxrwxrwx DYYH/mkpasswd    4867 2003-04-14 14:47:10 a2ps-4.12-1.sh
> > -rwxrwxrwx DYYH/mkpasswd 1831809 2003-04-14 14:47:10 a2ps-4.12.tar.gz
> >
> > That patch file looks like 800k to me...  It also contains a whole bunch
> > of generated files (e.g., Makefile).  Am I being fooled by the server
> > cache?
> >         Igor

--
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]