This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Sat, 12 Jul 2003, Max Bowsher wrote: > Igor Pechtchanski wrote: > > On 12 Jul 2003, Robert Collins wrote: > > > >> On Sat, 2003-07-12 at 01:20, Igor Pechtchanski wrote: > >>> The attached patch fixes erroneous quoting of the __LINE__ and __FILE__ > >>> macros in exception descriptions. > >> > >> Igor, do you have commit access to setup? If so, please apply this - > >> it's approved. > > > > Rob, > > > > I don't have commit rights. Max, could you please do the honors? > > Igor > > Not commiting. This patch causes compilation failiure on my machine. > Example error: > UserSettings.cc:66: error: syntax error before string constant > > BTW, unless I'm missing some subtlety on sources.redhat.com, you do appear > to have commit access. > > Max. Umm, what can I say except "Oops!"? Would you believe I redirected the make output to one file, and looked at another? Bizarre, isn't it? I've attached a (verified) working patch. As for the commit rights, I do have them for some directories in the cygwin-apps repository, but I was under the impression that those rights were on a per-directory basis. Igor ============================================================================== 2003-07-11 Igor Pechtchanski <pechtcha@cs.nyu.edu> * String++.h (TOSTRING): New macro. * UserSettings.cc (UserSettings::deRegisterSetting): Fix erroneous __LINE__/__FILE__ usage. * download.cc (validateCachedPackage, check_for_cached): Ditto. * geturl.cc (getUrlToStream): Ditto. * install.cc (md5_one): Ditto. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "I have since come to realize that being between your mentor and his route to the bathroom is a major career booster." -- Patrick Naughton
Attachment:
setup-exceptions-compileinfo.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |