Review: ploticus -- not yet good to go

["Rafael Kitover" <caelum at debian dot org>]

Problems with binary package:

/usr/doc needs to be /usr/share/doc
No runtime requirement on zlib
Binary needs to be recompiled because there's no longer a libz.dll that it
cannot load.
No man pages, source does come with manpages so they should be installed.

Problems with source package:

build script should be called "ploticus-2.11-1.sh" not "cygbuild-2.11-1.sh"

./ploticus-2.11-1.sh: line 402: [: -eq: unary operator expected
./ploticus-2.11-1.sh: line 402: [: -eq: unary operator expected

See: http://www.cygwin.com/ml/cygwin-apps/2004-01/msg00262.html 

Build script bundled with a package should not print out extraneous warnings
such as:

--    [WARN] Hm, there is no /tmp/cyg/ploticus-2.11/configure
--    [WARN] Found only a Makefile. Nothing to do.

and

--    Hm, archive did not extract into directory ploticus-2.11 ...
--    Renaming unpack dir plsrc211/ to ploticus-2.11

It is assumed the script for a particular package is tuned for that package and
knows what to do, you could add a "debug" variable somewhere at the top of your
cygbuild script.

./ploticus-2.11-1.sh all should clean up after itself and not leave a
ploticus-2.11 directory around.

-- 
Rafael