This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Review: otcl - not yet good to go


Major issue:

gcc -DHAVE_CONFIG_H -I. -I/tmp/cyg/otcl-1.0.9 -I.
-I/usr/src/tcltk-20030901-1/tcl/generic -O2 -MT otcl.lo -MD -MP -MF
.deps/otcl.Tpo -c /tmp/cyg/otcl-1.0.9/otcl.c  -DPIC -o .libs/otcl.o
/tmp/cyg/otcl-1.0.9/otcl.c:21:20: tclInt.h: No such file or directory

The file tclInt.h is nowhere in the binary package of tcltk, but seems to be
required to build.

I used the headers I found in insight CVS:
cp /src/tcl/generic/tclInt.h /usr/include
cp /src/tcl/generic/tclIntDecls.h /usr/include

And tried again, this time it built fine.

The package should have a note in the README about these files with
instructions on getting them, or include its own copy, or even automatically
fetch a copy from CVS into the source directory for the build.

Non-showstoppers:

Warnings such as:
/tmp/cyg/otcl-1.0.9/otcl.c: In function `OTclDispatch':
/tmp/cyg/otcl-1.0.9/otcl.c:418: warning: assignment discards qualifiers from
pointer target type
/tmp/cyg/otcl-1.0.9/otcl.c:420: warning: passing arg 4 of pointer to function
from incompatible pointer type
/tmp/cyg/otcl-1.0.9/otcl.c:428: warning: initialization discards qualifiers
from pointer target type
/tmp/cyg/otcl-1.0.9/otcl.c:460: warning: assignment discards qualifiers from
pointer target type
/tmp/cyg/otcl-1.0.9/otcl.c:463: warning: passing arg 4 of pointer to function
from incompatible pointer type
/tmp/cyg/otcl-1.0.9/otcl.c: In function `AutoLoader':
/tmp/cyg/otcl-1.0.9/otcl.c:524: warning: comparison of distinct pointer types
lacks a cast
/tmp/cyg/otcl-1.0.9/otcl.c:526: warning: passing arg 4 of pointer to function
from incompatible pointer type
/tmp/cyg/otcl-1.0.9/otcl.c: In function `MakeAuto':
/tmp/cyg/otcl-1.0.9/otcl.c:538: warning: assignment from incompatible pointer
type

Could be cleaned up with some casts, unless they indicate a more serious
problem.

It would be nice to have man pages for the "otclsh" and "owish" programs, they
could be stubs.

Patch is pretty big, if the auto stuff isn't upstream when you make a new
version, it might make sense to include automake/autoconf in the build
requirements, get rid of the generated files, and run automake from the package
script to keep the noise level down.

Also you seem to have gotten a backup file in there:
otcl-1.0.9/doc/Makefile.am~

The tutorial.html is good, but a running example or two would also be good.

Unrelated Oddities:

The build would hang half the time on 
/bin/bash /tmp/cyg/otcl-1.0.9/missing --run automake-1.7 --gnu  lib/Makefile
with 1.5.7 and a dll fresh from CVS.

-- 
Rafael



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]