This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Review: ploticus -- not yet good to go


Rafael Kitover wrote:

Build script bundled with a package should not print out extraneous warnings
such as:

--    [WARN] Hm, there is no /tmp/cyg/ploticus-2.11/configure
--    [WARN] Found only a Makefile. Nothing to do.

and

--    Hm, archive did not extract into directory ploticus-2.11 ...
--    Renaming unpack dir plsrc211/ to ploticus-2.11

It is assumed the script for a particular package is tuned for that package and
knows what to do, you could add a "debug" variable somewhere at the top of your
cygbuild script.

Disagree. This particular build tool is NOT completely tuned for each package -- it's "adapted" via fragments, just like cgf's mknetrel. But, it is a general build tool, not a "complete customization from a template" like generic-build-script.


PERHAPS cygbuild could be tuned to emitting no WARN or INFO messages by default...but IMO this should not be a requirement for inclusion of this package.

The other points (like shell script errors when running cygbuild!) are, of course, showstoppers.

./ploticus-2.11-1.sh all should clean up after itself and not leave a
ploticus-2.11 directory around.

Meh. Probably...but only because generic-build-script sets the expectation that './foo all' does so.


--
Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]