This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: new package: lighttpd


Hallo Jan,

Am Donnerstag, 16. September 2004 um 22:08 schriebst du:

> I would like to maintain me the cygwin-port of lighttpd, a really nice
> and cute webserver.

I vote pro this contribution.

> see http://jan.kneschke.de/projects/lighttpd/ for more information.

> setup.hint:

> sdesc: "a light-weight and flexible webserver"
> ldesc: "lighttpd a secure, fast, compliant and very flexible web-server
> which has been optimized for high-performance environments. It has a
> very low memory footprint compared to other webservers and takes care of
> cpu-load. Its advanced feature-set (FastCGI, CGI, Auth,
> Output-Compression, URL-Rewriting and many more) make lighttpd the
> perfect webserver-software for every server that is suffering load
> problems. "
> category: Net Web
> requires: pcre cygwin


> Files:
> http://jan.kneschke.de/projects/lighttpd/download/lighttpd-1.2.8-1.tar.bz2
> http://jan.kneschke.de/projects/lighttpd/download/lighttpd-1.2.8-1-src.tar.bz2

Short review, binary package:

Can we have the modules in a separate subdirectory, please?
Not:
usr/lib/mod_access.dll
usr/lib/mod_access.dll.a
usr/lib/mod_access.la
But:
usr/lib/lighttpd/mod_access.dll
usr/lib/lighttpd/mod_access.dll.a
usr/lib/lighttpd/mod_access.la

Can we have a real README instead of:
$ head usr/share/doc/Cygwin/lighttpd-1.2.8.README
<package name>
------------------------------------------
<short description, 2 or 3 lines>

[...]

With some information how to install as Cygwin service via cygrunsrv.

And could we have the docs in the binary package as well as a default
configuration file.  Also the document directory should be created
(should be /var/www/lightdocs or s.th. different under /var), as well
as other directories which are used should be created (/var/www/logs
etc.) This could be done via postinstall script.



Source package:
There are backup files included in the patch:
diff -urN -x .build -x .inst -x .sinst lighttpd-1.2.8-orig/CYGWIN-PATCHES/lighttpd.README~ lighttpd-1.2.8/CYGWIN-PATCHES/lighttpd.README~
--- lighttpd-1.2.8-orig/CYGWIN-PATCHES/lighttpd.README~ 1970-01-01 01:00:00.000000000 +0100
+++ lighttpd-1.2.8/CYGWIN-PATCHES/lighttpd.README~      2004-09-16 16:06:44.000000000 +0200


Why don't you include openssl support (default no)?

What about the other configure flags:
  --enable-mod-localizer  Turn on mod_localizer
  --with-ldap             enable LDAP support
  --with-attr             enable extended attribute support
?

Isn't localizer also open sourced or is there s.th. else needed to get
the localizer module up and running?  AFAICS, localizer builds without
changes (besides the missing -no-undefined flag to get a shared
library).

Wouldn't make it more sense to use --disable-static --enable-shared
instead of having all those static module files which are of no use?
Also the import libraries for the modules could be removed from the
binary tarball, and if you are not using dlopen, the .la files fr the
modules can be removed too.

The README at your website contains more information as the README
included in the source/binary tarballs.

I cannot rebuild from source:
rm -f configparser.h
../src/lemon -q /home/gerrit/lighttpd-1.2.8/src/configparser.y /home/gerrit/lighttpd-1.2.8/src/lempar.c
if sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -DLIBRARY_DIR="\"/usr/lib\"" -I. -I/home/gerrit/lighttpd-1.2.8/src -I..   -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_REENTRANT  -O2 -Wall -W -Wshadow -pedantic -MT config.lo -MD -MP -MF ".deps/config.Tpo" -c -o config.lo config.c; \
then mv -f ".deps/config.Tpo" ".deps/config.Plo"; else rm -f ".deps/config.Tpo"; exit 1; fi
 gcc -DHAVE_CONFIG_H -DLIBRARY_DIR=\"/usr/lib\" -I. -I/home/gerrit/lighttpd-1.2.8/src -I.. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_REENTRANT -O2 -Wall -W -Wshadow -pedantic -MT config.lo -MD -MP -MF .deps/config.Tpo -c config.c  -DPIC -o .libs/config.o
gcc: config.c: No such file or directory
gcc: no input files
make[2]: *** [config.lo] Error 1
make[2]: Leaving directory `/home/gerrit/lighttpd-1.2.8/.build/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/gerrit/lighttpd-1.2.8/.build'
make: *** [all] Error 2


It seems you're the upstream maintainer as well, wouldn't it make more
sense to release a new tarball with the changes included?



Gerrit
-- 
=^..^=



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]