This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Propagate exit codes of scripts to setup


Igor Pechtchanski wrote:

> As promised, here's a patch that makes Script::run() (and
> try_run_script()) return the exit code of the script.  This just sets up
> the infrastructure -- the exit code is currently ignored (well, logged),
> but that could be changed later in both Installer::preremoveOne(),
> packagemeta::uninstall(), and do_postinstall_thread().

Thanks, applied.  Although, I agree with Eric Blake's point that
postremove scripts are probably not a great idea, they're not documented
anywhere (that I know of), and the last package that used it has
switched to a preremove.  Therefore I killed the postremove support
entirely.

Brian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]