This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [g-b-s Patch: next try] Write and save logfiles for configure/make/check/install
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Igor Pechtchanski on 10/16/2005 4:35 PM:
>
> Ah, thanks, I wasn't aware that setup.html recommended running spkg right
> after mkdirs.
>
>
> This will still create an (empty) ${log_pkg_name} tarball, which will get
> included in the source package (making it a bit misleading).
>
> I've made the log tarball creation conditional on the existence of the log
> files. Thanks for bringing this matter up.
Still doesn't work. Your version only checks the existance of
configurelogname, but it is possible to have that and not all three of
{make,check,install}logname. For example, the newly uploaded
coreutils-5.90-3 does not have a check log (only configure, make, and
install). Part of the problem here is that 'g-b-s all' does not, by
default, run 'g-b-s check', although I'm not sure if we should change that.
Also, I recommend that make check be passed -k, so that the entire test
suite is run, rather than giving up on the first failure; after all, some
failures are bugs in the test suite (meaning non-portable tests that
cannot work in cygwin, but which haven't been patched to SKIP yet).
2005-10-17 Eric Blake <ebb9@byu.net>
* templates/generic-build-script (check): Run all tests.
(spkg): Don't fail if one of the four logs is missing.
- --
Life is short - so eat dessert first!
Eric Blake ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDU4vc84KuGfSFAYARAnmsAKCmxXT3lhJjSsgSvnr3bP7XuPKokwCg1RAe
6DLeQdYw/0sUqmG8vjhFnNo=
=+lRJ
-----END PGP SIGNATURE-----
Index: templates/generic-build-script
===================================================================
RCS file: /cvs/cygwin-apps/packaging/templates/generic-build-script,v
retrieving revision 1.41
diff -u -p -r1.41 generic-build-script
--- templates/generic-build-script 16 Oct 2005 22:29:49 -0000 1.41
+++ templates/generic-build-script 17 Oct 2005 11:32:30 -0000
@@ -226,7 +226,7 @@ build() {
}
check() {
(cd ${objdir} && \
- make ${test_rule} 2>&1 | tee ${checklogfile} )
+ make -k ${test_rule} 2>&1 | tee ${checklogfile} )
}
clean() {
(cd ${objdir} && \
@@ -356,9 +356,9 @@ spkg() {
fi && \
cd ${srcinstdir} && \
if [ -e ${configurelogname} ]; then
- tar cvjf ${log_pkg_name} \
+ tar --ignore-failed-read -cvjf ${log_pkg_name} \
${configurelogname} ${makelogname} ${checklogname} ${installlogname} && \
- rm \
+ rm -f \
${configurelogname} ${makelogname} ${checklogname} ${installlogname} ; \
fi && \
tar cvjf ${src_pkg} * )