This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [Patch] Setup: Warn about dropped mirrors.
- From: Bas van Gompel <cygwin-apps dot buzz at bavag dot tmfweb dot nl>
- To: cygwin-apps at cygwin dot com
- Date: Tue, 8 Nov 2005 22:07:31 +0100 (MET)
- Subject: Re: [Patch] Setup: Warn about dropped mirrors.
- Organisation: Ehm...
- References: <Pine.GSO.4.63.0510131116140.9865@slinky.cs.nyu.edu> <20051014144432.GA6807@trixie.casa.cgf.cx> <20051014161626.GL2908@calimero.vinschen.de> <43504A0C.BC4E87BA@dessent.net> <43504C5A.9BEACB9C@dessent.net> <Pine.GSO.4.63.0510161728350.1211@slinky.cs.nyu.edu> <n2m-g.dj1bor.3vv8pml.1@buzzy-box.bavag> <Pine.GSO.4.63.0510180131020.21802@slinky.cs.nyu.edu> <n2m-g.dj3tkk.3vv96rh.1@buzzy-box.bavag> <Pine.GSO.4.63.0510191712430.409@slinky.cs.nyu.edu> <n2m-g.dkbctp.3vv3gvj.1@buzzy-box.bavag>
- Reply-to: cygwin-apps mailing-list <cygwin-apps at cygwin dot com>
Op Wed, 2 Nov 2005 22:29:10 +0100 (MET) schreef Bas van Gompel
in <n2m-g.dkbctp.3vv3gvj.1<at>buzzy-box.bavag>:
: Op Wed, 19 Oct 2005 17:17:15 -0400 (EDT) schreef Igor Pechtchanski
[Using cached mirror-list]
: I didn't add the info to last-mirror, because that would make for more
: needlesly complicated code (IMO). I do add a comment to the newly
: written mirrors-lst file, though.
[...]
: --- setup/site.cc 14 Oct 2005 04:23:14 -0000 2.40
: +++ setup/site.cc 2 Nov 2005 20:11:16 -0000
[...]
: @@ -393,8 +575,16 @@ long
: SitePage::OnNext ()
: {
: HWND h = GetHWND ();
: + int cache_action;
Ouch, I missed a path through there which might leave cache_action
uninitialized. Therefore please apply following patch after this one.
--- setup/site.cc 2 Nov 2005 20:11:16 -0000
+++ setup/site.cc 8 Nov 2005 20:11:00 -0000
@@ -575,7 +575,7 @@ long
SitePage::OnNext ()
{
HWND h = GetHWND ();
- int cache_action;
+ int cache_action = CACHE_ACCEPT_NOWARN;
save_dialog (h);
L8r,
Buzz.
--
) | | ---/ ---/ Yes, this | This message consists of true | I do not
-- | | / / really is | and false bits entirely. | mail for
) | | / / a 72 by 4 +-------------------------------+ any1 but
-- \--| /--- /--- .sigfile. | |perl -pe "s.u(z)\1.as." | me. 4^re