This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: gamin-0.1.7
- From: Lapo Luchini <lapo dot luchini at gmail dot com>
- To: cygwin-apps at cygwin dot com
- Cc: Alessandro Premoli <a dot premoli at andxor dot it>
- Date: Thu, 16 Feb 2006 09:42:19 +0100
- Subject: Re: gamin-0.1.7
- References: <43D804B8.5010707@lapo.it> <20060125233034.GB19455@trixie.casa.cgf.cx> <43D81994.8020403@users.sourceforge.net> <43D8FDA4.2010409@lapo.it> <43D9426E.3080106@users.sourceforge.net> <43D955BF.8090102@users.sourceforge.net> <43DE244C.2030402@lapo.it> <43DEB2E4.2020106@users.sourceforge.net> <Pine.GSO.4.63.0601302011170.2628@access1.cims.nyu.edu> <43DECBA1.1030508@users.sourceforge.net> <43DF2F7F.7050203@lapo.it> <43E16CE2.9090307@users.sourceforge.net> <43F0A57A.5020505@lapo.it> <43F3DBD9.5050307@users.sourceforge.net>
Yaakov S (Cygwin Ports) wrote:
> I'm curious, I don't see that any of the defined(__CYGWIN__) checks
> next to the defined(__FreeBSD__) checks in your patch. Was that
> intentional?
Yes it was: those defines are about the cmsgcred socket credential
system, the first term of that test should always be false if there is
no "struct cmsgcred" in sys/socket.h
What do you think of the rest of the patch?
There are probably some things not strictly necessary (such as the
system to detect on what file system types to use kernel backend and on
what use polling, never called as I patched the function to always
return "polling"), but we first did a working FreeBSD patch and then
based the Cygwin patch on the same (managing only a smaller diff "over
the other diff" is easier).
Lapo