This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
[PATCH] Setup 1.7 command line install/download in setup.exe
- From: Ralph Hempel <rhempel at bmts dot com>
- To: cygwin-apps at cygwin dot com
- Date: Fri, 05 Dec 2008 11:24:37 -0500
- Subject: [PATCH] Setup 1.7 command line install/download in setup.exe
- References: <48BE93AB.5090005@bmts.com>
Some time ago, I mentioned on this list that the -D -L command
line options for setup.exe (1.7) don't operate quite the same as the
radio buttons on the setup dialog.
The operation I ended up describing was:
1. last-action should be consulted only if _neither_ -D nor -L are given
2. if -D is given, then download to local directory only
3. if -L is given, then install from local directory only
4. if both -D and -L are given, download and install
The attached patch to source.cc (HEAD) accomplishes this with
an absolute minimum set of changes. I have tested this patch using the
following command lines:
setup -L -> sets the radio button for a local install
setup -D -> sets the radio button for download only
setup -D -L -> sets the radio button for download and install
setup -> sets the radio button to the previous(default) state
Please consider adding this to the current setup.exe source.
Cheers, Ralph
--- setup-clean/source.cc 2008-08-12 16:32:08.000000000 -0400
+++ setup/source.cc 2008-09-03 09:29:28.593750000 -0400
@@ -86,7 +86,9 @@
void
SourcePage::OnActivate ()
{
- if (DownloadOption)
+ if (DownloadOption && LocalOption)
+ source = IDC_SOURCE_NETINST;
+ else if (DownloadOption)
source = IDC_SOURCE_DOWNLOAD;
else if (LocalOption)
source = IDC_SOURCE_CWD;