This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [patch] Fix setup.exe chooser page header column borkage.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 01 Jul 2009 09:23:21 +0100
- Subject: Re: [patch] Fix setup.exe chooser page header column borkage.
- References: <4A483A0E.8020109@gmail.com> <20090629040404.GA17911@ednor.casa.cgf.cx> <4A48C8A7.8000500@gmail.com> <20090629141300.GA19123@ednor.casa.cgf.cx> <4A48CF24.2090001@bmts.com> <20090629144008.GJ30864@calimero.vinschen.de> <20090629144512.GE19123@ednor.casa.cgf.cx> <4A4A484E.6030803@gmail.com> <20090630193916.GB9955@ednor.casa.cgf.cx>
Christopher Faylor wrote:
> On Tue, Jun 30, 2009 at 06:15:58PM +0100, Dave Korn wrote:
>> [ Heh. Legacy code FTW. To me it looks like some of the code was
>> developed in parallel with some of the developers learning the ins and
>> outs of writing big C++ applications for the first time. That's only
>> to be expected; there's a lot of stuff about a language that you just
>> don't learn until you really use it in anger for a while. Anyway, it
>> is what it is and it's not _that_ bad. ]
>
> Actually, I don't think anyone who wrote this part of the code would
> claim to have been learning c++.
It can be difficult to communicate clearly in email. Before I wrote that
paragraph, it had a specific example, but then I took it out because it might
look unfairly critical of the specific individual who contributed it, which it
wasn't meant to be. Unfortunately that left it ambiguously looking like I
might have been referring specifically to the code we're looking at now. I
wasn't!
>> Ok?
>
> Looks ok to me. Thanks for tracking this down.
Pleasure, it's been nagging at me for a while. Hooray for being unemployed
and actually having the spare time to spend on making things nice :)
cheers,
DaveK