This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] inform user if any postinstall script failed to run


On 12 August 2010 19:13, Christopher Faylor wrote:
>>> I think that wording will still cause consternation.
>>>
>>> Maybe we need something like:
>>>
>>> "This does not necessarily mean that the affected package will fail to
>>> function properly but if you do notice problems please check
>>> /var/log/setup.log.full ."
>>
>>How about removing the popup box and amending the postinstall results
>>page along those lines?
>
> I think removing the MessageBox is a good idea but I still think we
> should be slightly more reassuring about the errors. ÂThis might just
> be a temporary thing as package maintainers fix the problems in their
> scripts; assuming that they actually do that. ÂSo far the response has
> not been overwhelming.
>
> But assuming that the problems are all fixed then we can drop the
> assurance in a couple of months.

Take three:

Index: res.rc
===================================================================
RCS file: /cvs/cygwin-apps/setup/res.rc,v
retrieving revision 2.88
diff -u -r2.88 res.rc
--- res.rc      6 Aug 2010 18:56:12 -0000       2.88
+++ res.rc      12 Aug 2010 19:27:22 -0000
@@ -433,7 +433,9 @@
     ICON            IDI_CYGWIN,IDC_HEADICON,SETUP_HEADICON_X,0,21,20
     LTEXT           "Postinstall script errors",IDC_STATIC_HEADER_TITLE
                     ,7,0,258,8,NOT WS_GROUP
-    LTEXT           "The following errors occured executing
postinstall scripts",
+    LTEXT           "These don't necessarily mean that affected packages will "
+                    "fail to function properly, but if you do notice problems "
+                    "please check /var/log/setup.log.full.",
                     IDC_STATIC,21,9,239,16,NOT WS_GROUP
     EDITTEXT        IDC_POSTINSTALL_EDIT,7,41,303,124,WS_VSCROLL | WS_HSCROLL |
                     ES_LEFT | ES_MULTILINE | ES_READONLY | ES_AUTOHSCROLL |
Index: postinstallresults.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/postinstallresults.cc,v
retrieving revision 1.1
diff -u -r1.1 postinstallresults.cc
--- postinstallresults.cc       29 Jul 2010 13:09:04 -0000      1.1
+++ postinstallresults.cc       12 Aug 2010 19:27:22 -0000
@@ -54,15 +54,6 @@
 long
 PostInstallResultsPage::OnNext ()
 {
-  // one or more postinstall scripts failed to run successfully
-  // installation may be broken
-  MessageBox (NULL,
-              "You will need to investigate and correct these errors "
-              "before your Cygwin installation will function properly.\n"
-              "Check setup.log for details.",
-              "ERROR - postinstall scripts failed",
-              MB_OK | MB_ICONERROR | MB_SETFOREGROUND | MB_TOPMOST);
-
   return IDD_DESKTOP;
 }

(Turns out a line break is inserted automatically into the message, so
no need for \n.)

Andy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]