This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [Patch] Add rebase-dump application to rebase package
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Mon, 1 Aug 2011 09:56:38 +0200
- Subject: Re: [Patch] Add rebase-dump application to rebase package
- References: <4E32BCBA.6020808@cwilson.fastmail.fm>
- Reply-to: cygwin-apps at cygwin dot com
Hi Chuck,
On Jul 29 09:59, Charles Wilson wrote:
> As the title says.
>
> * Makefile.in: Add rules to build, but not install,
> rebase-dump.exe.
> * rebase-db.h: Declare new dump_rebasedb* functions.
> * rebase-db.c (dump_rebasedb_header): New function.
> (dump_rebasedb_entry): New function.
> (dump_rebasedb): New function.
> * rebase-dump.c: New file.
Looks good to me. As you probably noticed, I didn't manage to move
the db functions into rebase-dump.c so far, though. Otherwise there
wouldn't be a need to have your own load_image_info function.
Do you want me to do that before or after you applied your patch?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat