This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [patch/rebase] peflags.c: Use official file structures, make 64 bit capable
On Aug 5 18:18, Charles Wilson wrote:
> On 8/5/2011 8:51 AM, Corinna Vinschen wrote:
> > On Aug 5 13:17, Corinna Vinschen wrote:
> >> the below patch cleans up peflags so that it uses the official Windows
> >> types to access the COFF and PE flags via a memory map, rather than
> >> seek/read, seek/write to some undocumented byte offsets. This patch
> >> also makes peflags capable to read and change 64 bit files.
> >>
> >> Reading and writing other header info (namely stacksize) follows later.
> >>
> >> Patch builds and is tested on Cygwin and x86_64-mingw64.
> >>
> >> Ok to apply?
> >
> > Second service. I left in everything I only added for debugging a
> > problem I had with my the native mmap implementation. For some reason
> > the data was never written back to the file. Turned out I had used
> > "flags" instead of "prot" in the conditionals. That was already fixed
> > in the previous patch, but the debug stuff was really supposed to go away.
> >
> > Here we go, ChangeLog is unchanged...
>
> Looks good, builds cleanly and works correctly on mingw(32) and msys.
>
> Go ahead.
Thanks, applied.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat