This is the mail archive of the cygwin-apps mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
The change in crt/wchar.h about __mingw_ovr macro looks wrong to me, or at least inconsistent. As stdio.h has same macro. At least a libstdc++ bootstrap test is required for this change.
#undef __mingw_ovr -#ifdef __cplusplus -#define __mingw_ovr inline __cdecl -#elif defined (__GNUC__) +#if defined (__GNUC__) #define __mingw_ovr static __attribute__ ((__unused__)) __inline__ __cdecl +#elif defined(__cplusplus) +#define __mingw_ovr inline __cdecl #else #define __mingw_ovr static __cdecl #endif
The hunk in winnt.h: @@ -88,7 +88,7 @@ extern "C" {
#include<basetsd.h>
-#if defined(_X86_) || defined(__ia64__) || defined(__x86_64) +#if defined(__W32API_USE_DLLIMPORT__)&& (defined(_X86_) || defined(__ia64__) || defined(__x86_64)) #define DECLSPEC_IMPORT __declspec(dllimport) #else #define DECLSPEC_IMPORT
I would like to see here a different macro-name and the logic needs to be inverted. Our default scenario uses dllimport and just in cygwin's setup-case we don't want it. So I would like to see here instead: !defined (__NO_USE_DLLIMPORT)
Yaakov Cygwin/X
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |