This is the mail archive of the cygwin-apps mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Jon, On Nov 18 16:47, Jon TURNEY wrote: > > As was pointed out on IRC a week or two ago, setup can show a "The current ini > file is from a newer version of setup..." message box even in unattended mode. > > Attached is a patch to fix. > > There are other uses of MessageBox() which probably present a similar problem > and still need fixing. > > 2013-11-18 Jon TURNEY <...> > > * msg.cc (mbox): Generalize to a MessgeBox() wrapper which knows ^^^^^^^^^^^ typo. Also, just remove the "()", they are unnecessary. > what to do in unattended mode. > * msg.h: Add prototype. > * ini.cc (IniParseFeedback): Use here rather than MessageBox(). ^^ same here. Other than this minor ChangeLog nit, the patch looks good, please apply. If you fix further MessageBox usages to work fine in attended and unattended mode, consider them pre-approved. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
Attachment:
pgp48J2iJ7A8w.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |