Re: [RFC] incremental rebase

[Ken Brown <kbrown at cornell dot edu>]

On 11/28/2014 4:57 PM, Achim Gratz wrote:
> Achim Gratz writes:
> > New versions of the setup programs and incremental autorebase package
> > are uploaded, plus my original texlive postinstall (not modified for the
> > new setup) for Ken to look at.
>
> Correction:
> --8<---------------cut here---------------start------------->8---
> wget="wget -rxnH http://cygwin.stromeko.net/";
> $wget/x86/setup-x86.exe
> $wget/x86_64/setup-x86_64.exe
> $wget/noarch/release/_incautorebase/_incautorebase-00009-1.tar.xz
> $wget/noarch/release/_incautorebase/_incautorebase-00009-1-src.tar.xz
> $wget/noarch/release/_incautorebase/setup.hint
> $wget/noarch/release/zzz_texlive-postinstall/zzz_texlive-postinstall-00001-2.tar.bz2
> $wget/noarch/release/zzz_texlive-postinstall/zzz_texlive-postinstall-00001-2-src.tar.bz2
> $wget/noarch/release/zzz_texlive-postinstall/setup.hint
> --8<---------------cut here---------------end--------------->8---

Were the new setup programs built from what's currently at your Git 
repo?  If so, I have a couple of very minor comments:

> -  // Look for any scripts in /etc/postinstall which haven't been renamed .done
> -  std::string postinst = cygpath ("/etc/postinstall");
> +  // Look for runnable non-perpetual  scripts in /etc/postinstall
> +  // this shouldn't happen (leftovers from the previous install?)

This comment is slightly misleading.  It would be clearer to say 
something like, "This happens when a script from a previous install 
failed to run successfully."

> +Script::Script (const std::string& fileName)
> [...]
> +  if ( 2   == scriptBaseName.find('_') &&
> +       0   == scriptBaseName.substr(1,1).find_first_of(allowedTypes)  &&
> +       "_" != scriptBaseName.substr(0,1)

This last test is redundant, since we already know that 2 == 
scriptBaseName.find('_').

AFAICT, this is ready to go, except that you haven't yet implemented the 
sorting of the perpetual postinstall scripts in any given stratum.  And, 
of course, you will then have to rename 0p_incautorebase.dash to make 
sure it comes first in the perpetual postinstall scripts in stratum 0.

Thanks for showing me your old TeX Live postinstall package.  It doesn't 
differ too much from what I posted in 
https://cygwin.com/ml/cygwin-apps/2014-11/msg00141.html, though I could 
probably use your ideas to shave off a few more seconds.

Ken