This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: cmake update needed
- From: Yaakov Selkowitz <yselkowitz at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 04 Feb 2015 21:40:12 -0600
- Subject: Re: cmake update needed
- Authentication-results: sourceware.org; auth=none
- References: <54D1F25E dot 20701 at gmail dot com> <BAY169-DS1438076617CAC9B60DFC2CA73A0 at phx dot gbl> <1423093749 dot 596 dot 11 dot camel at cygwin dot com> <BAY169-DS20D64B9DEEF05161FF6EEFA73B0 at phx dot gbl>
On Wed, 2015-02-04 at 16:08 -0800, Tony Kelman wrote:
> > Obviously the patches to the modules won't affect the build of cmake
> > itself, but they do affect the building of other packages using cmake.
> > These patches were all added over years of testing and usage, and are
> > required for a useful cmake package.
>
> Sure. Were the reasons for them ever written down? If I'm going to
> maintain the package, I do not want to carry local patches forever.
Given our past experience[1][2] in working with upstream, anyone who
maintains a working cmake is going to have to carry patches long-term,
if not permanently.
[1] http://www.cmake.org/Bug/view.php?id=10122
[2] http://www.cmake.org/pipermail/cmake/2010-October/040353.html and
thread
> CMake's test suite is very extensive, if it's missing use cases that
> are specific to Cygwin then I'm sure upstream would be willing to add
> add more tests to catch them in the future. I'm willing to pursue
> upstreaming the patches wherever possible, but need test cases to do
> so. I've made this request once or twice before and it was ignored.
All these patches are the result of years of real-world usage of cmake,
and there will likely be more patches required in the future. I can't
tell you off the top of my head which packages require each of these
changes, but I can tell you why they are necessary (and a few of them
should be quite obvious).
--
Yaakov