This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup 3/4] Log errors from archive_tar.cc


On Mar  5 15:09, Jon TURNEY wrote:
> On 05/03/2015 14:17, Corinna Vinschen wrote:
> >On Mar  5 13:44, Jon TURNEY wrote:
> >>@@ -170,8 +163,8 @@ archive_tar::next_file_name ()
> >>    sscanf (state.tar_header.size, "%Io", &state.file_length);
> >>    state.file_offset = 0;
> >>
> >>-//  vp2 (_tar_vfile, "%c %9d %s\n", state.tar_header.typeflag,
> >>-//      state.file_length, state.filename);
> >>+  LogBabblePrintf ("%c %9d %s\n", state.tar_header.typeflag,
> >>+                   state.file_length, state.filename);
> >
> >Is it really worth to add this to the babble?
> 
> Erm no.  This should stay under 'if (_tar_verbose)' or something.

Yeah.  With this change, push it.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpPnXukfRja3.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]