This is the mail archive of the
mailing list for the Cygwin project.
- From: Achim Gratz <Stromeko at nexgo dot de>
- To: cygwin-apps at cygwin dot com
- Date: Thu, 11 Jun 2015 20:10:42 +0200
- Subject: Re: setup
- Authentication-results: sourceware.org; auth=none
- References: <20150608132823 dot GN3416 at calimero dot vinschen dot de> <87oakqnkfi dot fsf at Rainer dot invalid> <20150608193154 dot GU3416 at calimero dot vinschen dot de> <878ubtor9g dot fsf at Rainer dot invalid> <20150609095604 dot GA4993 at calimero dot vinschen dot de> <874mmghlf8 dot fsf at Rainer dot invalid> <20150610080526 dot GC31537 at calimero dot vinschen dot de> <871thjtq0m dot fsf at Rainer dot invalid> <20150610185417 dot GL31537 at calimero dot vinschen dot de> <87wpzbs2yj dot fsf at Rainer dot invalid> <20150611100607 dot GA14763 at calimero dot vinschen dot de>
Corinna Vinschen writes:
> Ok, I took a look. Basically it looks fine, but it seems there's a bug
> in terms of sig_fail.
Oh yes, that's buggered up.
> You're giving sig_fail as argument to fetch_remote_ini. Inside
> fetch_remote_ini, you're setting sig_fail, but you never test it.
> However, since sig_fail has been given to fetch_remote_ini by value,
> not by reference, the caller will never see the change to sig_fail.
Yes, that should have been a bool&.
> So in the expression
> if (!ini_file && !sig_fail)
> sig_fail is always false.
> I'm also wondering of the new logic at this point. If you fix the above
> call by value of sig_fail, the new logic will only continue if there
> was no sig test fail. It will not continue if there was no ini file,
> as it did before. Why?
When I pulled the two conditions into one, I just didn't get the logic
right. I'll rework that later.
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf rackAttack V1.04R1: