This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH setup] Send User-Agent even when setup-specific proxy is used

From: Jon Turney <jon dot turney at dronecode dot org dot uk>
To: cygwin-apps at cygwin dot com
Cc: SZAVAI Gyula <szgyg at ludens dot elte dot hu>
Date: Fri, 19 Jan 2018 14:18:10 +0000
Subject: Re: [PATCH setup] Send User-Agent even when setup-specific proxy is used
Authentication-results: sourceware.org; auth=none
References: <20180118191654.GB4212@MAY>

On 18/01/2018 19:16, SZAVAI Gyula wrote:

Setup is sending User-Agent header if direct connection or system proxy
is used, but not when direct(legacy) or setup-specific proxy. Fix this.

Thanks for the patch.

This is fine, as far as it goes. However, I don't think'direct(legacy)' is actually doing anything useful these days, so I'dkind of like to remove it (and all the hand-built protocol handlingunderneath it), and instead teach NetIO_IE5 how to handle asetup-specific proxy configuration as well.

Follow-Ups:
- Re: [PATCH setup] Send User-Agent even when setup-specific proxy is used
  - From: szgyg
- Remove legacy networking code
  - From: SZAVAI Gyula

References:
- [PATCH setup] Send User-Agent even when setup-specific proxy is used
  - From: SZAVAI Gyula

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]