This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup libsolv, v2] Let the user review added dependencies


On 1/24/2018 3:30 PM, Jon Turney wrote:
On 22/01/2018 17:37, Ken Brown wrote:
If the solver found no problems but added packages to resolve
dependencies, ask the user whether they want to review the added
packages before proceeding.

If they answer Yes, go back to the chooser with the 'Pending' view
selected.  The implementation adds several new members to the
PrereqChecker class so that the latter can communicate with the
chooser page.

As discussed, this approach could be confusing.

Attached is a slightly different approach, which adds a new page to review and confirm what actions we're going to take.

For the moment, this just contains a simple text report, but I guess this could be extended e.g. to use a grid control, or give reasons for why packages are being installed.

I like this a lot.  It's *much* better than my approach.

My only suggestion is that you rethink what the confirm page should do in "download only" mode. Maybe that page could even be skipped. But if you think the user should confirm the download, there's no need to mention "uninstall" actions, and "install" actions should be reported as "download".

Ken


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]