This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] Fix typo which might break permission evaluation


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=fcd8a0d4f4e9750ab2ddccb64318bf7a495af4ef

commit fcd8a0d4f4e9750ab2ddccb64318bf7a495af4ef
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Sat Mar 12 17:57:34 2016 +0100

    Fix typo which might break permission evaluation
    
    	* sec_acl.cc (get_posix_access): Fix a typo checking for a_id
    	rather than a_type.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/sec_acl.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/sec_acl.cc b/winsup/cygwin/sec_acl.cc
index 1919fb7..c99e056 100644
--- a/winsup/cygwin/sec_acl.cc
+++ b/winsup/cygwin/sec_acl.cc
@@ -1124,7 +1124,7 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
 	  }
 	/* For all groups, if everyone has more permissions, add everyone
 	   perms to group perms.  Skip groups with deny ACE. */
-	else if (lacl[idx].a_id & (GROUP_OBJ | GROUP)
+	else if (lacl[idx].a_type & (GROUP_OBJ | GROUP)
 		 && !(lacl[idx].a_type & ACL_DEFAULT)
 		 && !(lacl[idx].a_perm & DENY_RWX))
 	  lacl[idx].a_perm |= lacl[2].a_perm & S_IRWXO;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]