This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] The address of an class always evaluates to true


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=1eb7cb2553e5643395869814914ff0344ce5af51

commit 1eb7cb2553e5643395869814914ff0344ce5af51
Author: Peter Foley <pefoley2@pefoley.com>
Date:   Sat Mar 19 13:45:53 2016 -0400

    The address of an class always evaluates to true
    
    winsup/cygwin/pinfo.cc:465:14: error: the compiler can assume that the
    address of 'tc' will always evaluate to 'true' [-Werror=address]
    
    winsup/cygwin/ChangeLog
    * pinfo.cc (_pinfo::set_ctty): remove always true check.
    
    Signed-off-by: Peter Foley <pefoley2@pefoley.com>

Diff:
---
 winsup/cygwin/pinfo.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc
index be32cfd..23861e5 100644
--- a/winsup/cygwin/pinfo.cc
+++ b/winsup/cygwin/pinfo.cc
@@ -462,7 +462,7 @@ _pinfo::set_ctty (fhandler_termios *fh, int flags)
 {
   tty_min& tc = *fh->tc ();
   debug_printf ("old %s, ctty device number %y, tc.ntty device number %y flags & O_NOCTTY %y", __ctty (), ctty, tc.ntty, flags & O_NOCTTY);
-  if (fh && &tc && (ctty <= 0 || ctty == tc.ntty) && !(flags & O_NOCTTY))
+  if (fh && (ctty <= 0 || ctty == tc.ntty) && !(flags & O_NOCTTY))
     {
       ctty = tc.ntty;
       if (cygheap->ctty != fh->archetype)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]