This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] Drop has_broken_rtl_query_process_debug_information flag
- From: Corinna Vinschen <corinna at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 24 Jun 2016 14:36:27 -0000
- Subject: [newlib-cygwin] Drop has_broken_rtl_query_process_debug_information flag
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8dd446a7b139dc69800fd70c6a7835ee5a9f8364
commit 8dd446a7b139dc69800fd70c6a7835ee5a9f8364
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Tue Dec 15 16:06:51 2015 +0100
Drop has_broken_rtl_query_process_debug_information flag
Diff:
---
winsup/cygwin/fhandler_process.cc | 4 ----
winsup/cygwin/wincap.cc | 11 -----------
winsup/cygwin/wincap.h | 2 --
3 files changed, 17 deletions(-)
diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_process.cc
index 7efbc1f..f92decd 100644
--- a/winsup/cygwin/fhandler_process.cc
+++ b/winsup/cygwin/fhandler_process.cc
@@ -589,10 +589,6 @@ struct heap_info
NTSTATUS status;
PDEBUG_HEAP_ARRAY harray;
- /* FIXME? RtlQueryProcessDebugInformation/CreateToolhelp32Snapshot both
- crash the target process on 64 bit XP/2003 in native 64 bit mode. */
- if (wincap.has_broken_rtl_query_process_debug_information ())
- return;
buf = RtlCreateQueryDebugBuffer (16 * 65536, FALSE);
if (!buf)
return;
diff --git a/winsup/cygwin/wincap.cc b/winsup/cygwin/wincap.cc
index f94390d..3b9327b 100644
--- a/winsup/cygwin/wincap.cc
+++ b/winsup/cygwin/wincap.cc
@@ -27,7 +27,6 @@ wincaps wincap_xpsp2 __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:false,
has_precise_system_time:false,
has_microsoft_accounts:false,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:false,
has_broken_prefetchvm:false,
has_new_pebteb_region:false,
@@ -44,7 +43,6 @@ wincaps wincap_2003 __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:false,
has_precise_system_time:false,
has_microsoft_accounts:false,
- has_broken_rtl_query_process_debug_information:true,
has_processor_groups:false,
has_broken_prefetchvm:false,
has_new_pebteb_region:false,
@@ -61,7 +59,6 @@ wincaps wincap_vista __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:false,
has_precise_system_time:false,
has_microsoft_accounts:false,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:false,
has_broken_prefetchvm:false,
has_new_pebteb_region:false,
@@ -78,7 +75,6 @@ wincaps wincap_7 __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:true,
has_precise_system_time:false,
has_microsoft_accounts:false,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:true,
has_broken_prefetchvm:false,
has_new_pebteb_region:false,
@@ -95,7 +91,6 @@ wincaps wincap_8 __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:true,
has_broken_prefetchvm:false,
has_new_pebteb_region:false,
@@ -112,7 +107,6 @@ wincaps wincap_10 __attribute__((section (".cygwin_dll_common"), shared)) = {
has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:true,
has_broken_prefetchvm:true,
has_new_pebteb_region:false,
@@ -129,7 +123,6 @@ wincaps wincap_10_1511 __attribute__((section (".cygwin_dll_common"), shared)) =
has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
- has_broken_rtl_query_process_debug_information:false,
has_processor_groups:true,
has_broken_prefetchvm:false,
has_new_pebteb_region:true,
@@ -199,10 +192,6 @@ wincapc::init ()
/* 64 bit systems have one more guard page than their 32 bit counterpart. */
++((wincaps *)caps)->def_guard_pages;
#else
- /* RtlQueryProcessDebugInformation/CreateToolhelp32Snapshot both crash the
- target process on 64 bit XP/2003 in native 64 bit mode only. Reset the
- flag here for 32 bit. */
- ((wincaps *)caps)->has_broken_rtl_query_process_debug_information = false;
/* Windows 10 1511 has a stack move when a 64 bit process is started from
a 32 bit process, just as it was vice versa in XP/2003. Reset the flag
here for 32 bit. */
diff --git a/winsup/cygwin/wincap.h b/winsup/cygwin/wincap.h
index e9ac862..14837f7 100644
--- a/winsup/cygwin/wincap.h
+++ b/winsup/cygwin/wincap.h
@@ -20,7 +20,6 @@ struct wincaps
unsigned has_console_logon_sid : 1;
unsigned has_precise_system_time : 1;
unsigned has_microsoft_accounts : 1;
- unsigned has_broken_rtl_query_process_debug_information : 1;
unsigned has_processor_groups : 1;
unsigned has_broken_prefetchvm : 1;
unsigned has_new_pebteb_region : 1;
@@ -62,7 +61,6 @@ public:
bool IMPLEMENT (has_console_logon_sid)
bool IMPLEMENT (has_precise_system_time)
bool IMPLEMENT (has_microsoft_accounts)
- bool IMPLEMENT (has_broken_rtl_query_process_debug_information)
bool IMPLEMENT (has_processor_groups)
bool IMPLEMENT (has_broken_prefetchvm)
bool IMPLEMENT (has_new_pebteb_region)