This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] cygwin: unlink: improve debug messages in try_to_bin
- From: Corinna Vinschen <corinna at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 18 Oct 2017 14:29:32 -0000
- Subject: [newlib-cygwin] cygwin: unlink: improve debug messages in try_to_bin
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3dda58f1573a7e216f4656a3248252aea4f30593
commit 3dda58f1573a7e216f4656a3248252aea4f30593
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Wed Oct 18 16:18:12 2017 +0200
cygwin: unlink: improve debug messages in try_to_bin
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/syscalls.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 96fb6f3..e64b017 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -520,6 +520,8 @@ try_to_bin (path_conv &pc, HANDLE &fh, ACCESS_MASK access, ULONG flags)
bin_stat = dir_not_empty;
goto out;
}
+ debug_printf ("Renaming dir %S back to %S failed, status = %y",
+ &recycler, pc.get_nt_native_path (), status);
}
/* In case of success, restore R/O attribute to accommodate hardlinks.
That leaves potentially hardlinks around with the R/O bit suddenly
@@ -548,7 +550,8 @@ try_to_bin (path_conv &pc, HANDLE &fh, ACCESS_MASK access, ULONG flags)
NULL, 0);
if (!NT_SUCCESS (status))
{
- debug_printf ("Creating file for overwriting failed, status = %y",
+ debug_printf ("Creating file %S for overwriting %S (%S) failed, "
+ "status = %y", &fname, &recycler, pc.get_nt_native_path (),
status);
goto out;
}
@@ -556,7 +559,8 @@ try_to_bin (path_conv &pc, HANDLE &fh, ACCESS_MASK access, ULONG flags)
FileRenameInformation);
NtClose (tmp_fh);
if (!NT_SUCCESS (status))
- debug_printf ("Overwriting with another file failed, status = %y", status);
+ debug_printf ("Overwriting %S (%S) with %S failed, status = %y",
+ &recycler, pc.get_nt_native_path (), &fname, status);
out:
if (rootdir)