Re: src/winsup/w32api ChangeLog include/commdlg.h ...

["Larry Hall (RFK Partners, Inc)" <lhall at rfk dot com>]

At 11:24 AM 12/4/2001, Earnie Boyd wrote:
>"Larry Hall (RFK Partners, Inc)" wrote:
> > 
> > At 10:51 AM 12/4/2001, Christopher Faylor wrote:
> > >On Tue, Dec 04, 2001 at 03:21:39PM +0100, Corinna Vinschen wrote:
> > > >On Tue, Dec 04, 2001 at 09:07:16AM -0500, Earnie Boyd wrote:
> > > >> I was coming to that conclusion.
> > > >>
> > > >> Thanks,
> > > >> Earnie.
> > > >>
> > > >> Robert Collins wrote:
> > > >> >
> > > >> > I believe that IDC_STATIC is _meant_ to be defined by the application -
> > > >> > see the second hit on that Google list for example.
> > > >> > ==
> > > >> > #ifdef IDC_STATIC
> > > >> > #undef IDC_STATIC
> > > >> > #endif
> > > >> > #define IDC_STATIC      (-1)
> > > >> > ==
> > > >
> > > >And FWIW, a global grep in the Platform SDK include dir doesn't show
> > > >any match for IDC_STATIC.
> > >
> > >I find it defined in winuser.h in the header files that come with MSVC 6.
> > 
> > Boy is my face red!  Chris, of course, is right.  I find IDC_STATIC
> > defined in multiple MSVC include files including AFXRES.H and WINRES.H.
> > While it is defined in the project specific resource.h files as needed,
> > there must also be references to it at the system level that make it
> > at least convenient to define it at the system level as well.
> > 
> > So it looks like is valid to define IDC_STATIC at the system level...
> > 
>
>Can you find an msdn document that says it belongs here or there?



You're joking, right? ;-)

Well, I did the same search you probably did (just for the "fun" of it).
I don't think this is one of those things were it's "defined".  Given the
fact that it shows up in a handful of files, it seems pretty clear to me
that it's defined where someone decided it was needed.  So, if you're 
concerned that it should only be included at the system level if it's
"standard" to do so, I would suggest that it not be included unless the
need arises (comparable to the MS approach).




Larry Hall                              lhall@rfk.com
RFK Partners, Inc.                      http://www.rfk.com
838 Washington Street                   (508) 893-9779 - RFK Office
Holliston, MA 01746                     (508) 893-9889 - FAX