Question re: mntent::mnt_type in fillout_mntent (path.cc)

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

Hi, all!

After a recent discussion of df on the cygwin mailing list (
http://www.cygwin.com/ml/cygwin/2002-09/msg00945.html ), I've browsed
the source of getmntent, which eventually led me to fillout_mntent in
path.cc.

Is there some reason "user" or "system" is returned as the filesystem
type?  Shouldn't this be part of mnt_opts, with the mnt_type reflecting
rather the actual filesystem type, as returned by GetVolumeInformation
(perhaps POSIXified)?

I'm contemplating making that change, so users can see the actual
filesystem types (e.g., "cdrom", "ntfs", "net", etc) in df, mount and
other programs...  Does this sound like a terrible idea?  If it is
changed, can this introduce subtle bugs somewhere else?

I thought I should run it by this list first, before I invest too much
time.  Comments?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51