This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] change to thread.cc -- need feedback


On Tue, Oct 01, 2002 at 07:08:10AM +1000, Robert Collins wrote:
>On Tue, 2002-10-01 at 01:12, Christopher Faylor wrote:
>> I've changed the static declarations in thread.cc to use
>> NO_COPY and things seem to be working better in my build.
>
>I've tweaked this a little. pthread_key::keys needs to be copied.

Ok.

>pthreadNULL doesn't care either way - if NO_COPY is more efficient on
>forks, then it can be made NO_COPY.

NO_COPY is more efficient.  fork doesn't copy the data.

>The pthread_mutex::inializationMutex should be NO_COPY, as the handle
>isn't inheritable anyway (by design).

Would it make sense to use a critical section here, then, instead?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]