This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: gethostname() patch
- From: "Sergey Okhapkin" <sos at sokhapkin dot dyndns dot org>
- To: <cygwin-developers at cygwin dot com>
- Date: Fri, 10 Jan 2003 07:18:01 -0500
- Subject: Re: gethostname() patch
- References: <20030110130259.E1401@cygbert.vinschen.de>
Two notes:
1. Why do you call set_winsock_errno() but not set_errno() if
GetComputerName() failed?
2. You're comparing the return value of gethostname() with SOCKET_ERROR.
What the return value will be if TCPIP is not installed?
Sergey Okhapkin
Somerset, NJ
----- Original Message -----
From: "Corinna Vinschen" <vinschen@redhat.com>
To: <cygwin-developers@cygwin.com>
Sent: Friday, January 10, 2003 7:02 AM
Subject: gethostname() patch
> Hi,
>
> I've just removed some old cruft from cygwin_gethostname which had
> the annoying result that always the return value of GetComputerName()
> has been used instead of the return value of gethostname(). Now
> Cygwin's gethostname and hostname(1) report the winsock value of the
> hostname which is lower case.
>
> My questions is: Shouldn't uname call this function as well? Uname
> still uses the upper case value returned from GetComputerName().
>
> Corinna
>
> --
> Corinna Vinschen Please, send mails regarding Cygwin to
> Cygwin Developer mailto:cygwin@cygwin.com
> Red Hat, Inc.
>