This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: /cygdrive in CVS? Time for 1.5.6 soon.


On Mon, Dec 01, 2003 at 01:23:47PM -0500, Nicholas Wourms wrote:
> Actually, you might want check this against the original LTP source.  If 
> you look at the original, I think it makes more sense (at least to me), 
> since this logic was setting the l_type based on the size of a counter 
> in a for loop.  Breifly, this is a portion of the difference as compared 
> to our version 0f fcntl09:
> 
> <<<diff -u fcntl09.c.ltp fcntl09.c.cygwin>>>
>   for (lc=0; TESTLOOPING
> -  int type;
> -  for (type = 0, type < 2; type++){
> 
>     Tst_count=0;
> 
> -   flocks.l_type = type ? F_RDLCK : F_WRLCK;
> +   flocks.l_type = F_RDLCK : F_WRLCK;

Yes, that makes a lot more sense.  Interested to submit a patch?

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]