This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: mount.exe's error message
- To: cygwin-patches at cygwin dot com
- Subject: Re: mount.exe's error message
- From: Christopher Faylor <cgf at redhat dot com>
- Date: Tue, 28 Aug 2001 14:48:09 -0400
- References: <3B8BDD70.18800.1904953@localhost>
- Reply-To: cygwin-patches at cygwin dot com
On Tue, Aug 28, 2001 at 06:05:36PM +0200, Gerrit P. Haase wrote:
>Hi,
>
>I think this error message is not 'correct'.
>
>$ mount -s -b
>mount: too many arguments
>[...]
You're right. It's not correct. Your change would only make the
error message correct when there weren't enough arguments, though.
Too many arguments is also a possible error condition.
I checked in a fix which deals with both scenarios.
Thanks for noticing this.
cgf
>diff -ur src/winsup/utils/mount.cc src-patched/winsup/utils/mount.cc
>--- src/winsup/utils/mount.cc Tue Aug 28 14:19:39 2001
>+++ src-patched/winsup/utils/mount.cc Tue Aug 28 15:53:50 2001
>@@ -214,7 +214,7 @@
> default:
> if (optind != (argc - 1))
> {
>- fprintf (stderr, "%s: too many arguments\n", progname);
>+ fprintf (stderr, "%s: too few arguments\n", progname);
> usage ();
> }
> if (force || !mount_already_exists (argv[optind + 1], flags))
>
>
>Gerrit
>
>
>--
>gerrit.haase@convey.de
--
cgf@cygnus.com Red Hat, Inc.
http://sources.redhat.com/ http://www.redhat.com/