This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] cinstall - "setup grabbing memory by the bucketfull"problem found


On Wed, 2001-11-07 at 20:42, Pavel Tsekov wrote:

> Ok now about the patch - I'm just attaching it for review if someone
> decides
> to apply it I'll provide a Changelog. What I think is that this is not
> the best
> solution to the problem (though it works just fine) - a better one maybe
> will be
> some more checking in the SimpleSocket class.

Agreed - more checking in SimpleSocket.

> However I understand that
> the name
> Simple implies simplicity :) and as such the designers of this class

>From what I could see, SimpleSocket does perform error checking...

DJ, ohhhh DJ, what was the intent in SimpleSocket?

> decided to
> leave the error checking for the caller, not the object itself. So my
> patch
> complies with this and just check  if the object is valid after its
> creation.

Please submit a patch for this, with more checking in simplesocket, and
the ftp change for MS borken servers...


Thanks!
Rob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]