This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] cinstall - "setup grabbing memory by the bucketfull"problem found
- To: Pavel Tsekov <ptsekov at syntrex dot com>
- Subject: Re: [PATCH] cinstall - "setup grabbing memory by the bucketfull"problem found
- From: Robert Collins <robert dot collins at itdomain dot com dot au>
- Date: 08 Nov 2001 00:12:45 +1100
- Cc: cygwin-patches at cygwin dot com
- References: <OE59HpQHyD1C0Ug8cpF00003953@hotmail.com><1005045929.5221.0.camel@lifelesswks> <3BE7CA86.2EBAC42D@syntrex.com><3BE7DFE6.E8062434@syntrex.com> <1005052267.2726.19.camel@lifelesswks><3BE7F07A.1418CA29@syntrex.com> <20011106115722.B7437@redhat.com> <3BE90213.EEE91372@syntrex.com>
On Wed, 2001-11-07 at 20:42, Pavel Tsekov wrote:
> Ok now about the patch - I'm just attaching it for review if someone
> decides
> to apply it I'll provide a Changelog. What I think is that this is not
> the best
> solution to the problem (though it works just fine) - a better one maybe
> will be
> some more checking in the SimpleSocket class.
Agreed - more checking in SimpleSocket.
> However I understand that
> the name
> Simple implies simplicity :) and as such the designers of this class
>From what I could see, SimpleSocket does perform error checking...
DJ, ohhhh DJ, what was the intent in SimpleSocket?
> decided to
> leave the error checking for the caller, not the object itself. So my
> patch
> complies with this and just check if the object is valid after its
> creation.
Please submit a patch for this, with more checking in simplesocket, and
the ftp change for MS borken servers...
Thanks!
Rob