This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: /proc and /proc/registry


On Wed, Feb 27, 2002 at 11:57:30PM -0000, Chris January wrote:
>> On Tue, Feb 26, 2002 at 12:39:47PM -0000, Chris January wrote:
>> >> 1) The copyrights still need to be changed.
>> >Done.
>> >> 2) The code formatting still is not correct.
>> >Now piped through indent with a few touch-ups.
>> >> 3) You have a lot of calls to normalize_posix_path.  Is that really
>> >>    necessary?  It seems to be called a lot.  If it is really necessary,
>> >>    I'd prefer that it just be called in dtable::build_fhandler and made
>> >>    the standard "unix_path_name".
>> >Done.
>> >> 4) Could you generate the diff using 'cvs diff -up"
>> >Done. The new files are diff'ed against /dev/null and are appended to the
>> >output of cvs diff.
>
><--snip-->
>
>> Phew.
>
>Please find attached another patch with modifications as per your comments.
>I don't have much time to work on this anymore so this will have to be the
>last patch. ChangeLog is as before.

Despite my trepidations about committing something where the submitter
says he has no more time, I've committed this patch.

It was just too cool to be able to do 'ls /proc/registry'.

Thanks,
cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]