This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Reorganizing internal_getlogin() patch is in

From: Christopher Faylor <cgf at redhat dot com>
To: cygwin-patches at cygwin dot com
Date: Sun, 16 Jun 2002 01:47:56 -0400
Subject: Re: Reorganizing internal_getlogin() patch is in
References: <20020613052709.GA17779@redhat.com> <20020613052709.GA17779@redhat.com> <3.0.5.32.20020616000701.007f7df0@mail.attbi.com> <20020616051506.GA6188@redhat.com>
Reply-to: cygwin-patches at cygwin dot com

On Sun, Jun 16, 2002 at 01:15:06AM -0400, Christopher Faylor wrote:
>>c) adding a member "namelen" in spenv (as in win_env) seems to be helpful.
>
>Possibly, but this is one of those situations where you sully your patch
>by making it do too many things.  It's generally good practice to have
>one idea per patch.

FWIW, I've checked in a variation of this patch.  Your method actually
had some use in another place in environ.cc, too.

cgf

References:
- Reorganizing internal_getlogin() -- modified Pierre patch
  - From: Christopher Faylor
- Re: Reorganizing internal_getlogin() patch is in
  - From: Pierre A. Humblet
- Re: Reorganizing internal_getlogin() patch is in
  - From: Christopher Faylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]