This is the mail archive of the
mailing list for the Cygwin project.
Re: Reorganizing internal_getlogin() patch is in
On Sun, Jun 16, 2002 at 01:15:06AM -0400, Christopher Faylor wrote:
>>c) adding a member "namelen" in spenv (as in win_env) seems to be helpful.
>Possibly, but this is one of those situations where you sully your patch
>by making it do too many things. It's generally good practice to have
>one idea per patch.
FWIW, I've checked in a variation of this patch. Your method actually
had some use in another place in environ.cc, too.