This is the mail archive of the
mailing list for the Cygwin project.
RE: Resubmission of cygwin_daemon patch.
- From: "Robert Collins" <robert dot collins at syncretize dot net>
- To: "'Conrad Scott'" <Conrad dot Scott at dsl dot pipex dot com>,<cygwin-patches at cygwin dot com>
- Date: Sun, 23 Jun 2002 17:58:19 +1000
- Subject: RE: Resubmission of cygwin_daemon patch.
Ok, I've got some feedback for you...
I need to have a good think about some of what's being presented.
The following things are unconditionally good:
The pure virtual transport changes
The recoverable approach, and instance detection changes. (actually, I'd
like to suggest a global mutex be owned and tested against rather than
checking for the socket being present. But that's orthogonal).
Command line help
I'll be extracting the above and committing to head sometime shortly
after 1.3.11 gets released. Or if that doesn't happen within a week,
then soon anyway :}.
On the thoughtful side:
There seems to be a lot of code duplication - definitions copied to make
private versions, that sort of thing. Can you elaborate on why? I
strongly prefer to only have one instance of such things to prevent skew
Why have you removed the __OUTSIDE_CYGWIN__ for cygserver_shm.cc ?
That's all for now, gotta run - sorry.