This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: printfs in cygserver?


"Christopher Faylor" <cgf@redhat.com> write:
> There seems to be a lot of of "printfs" in cygserver code that
is
> apparently linked into cygwin.  I specifically noticed it it
> cygserver_transport_pipes.cc and cygserver_transport_sockets.cc.
> Is this being corrected?  We don't use raw printf in cygwin
code.

I've fixed this on the cygwin_daemon branch.  In case it's
something you'd like fixed immediately, attached is a (slightly
updated) copy of a patch I previously submitted to Rob that, among
other things, changes the cygserver code to use the xxx_printf
calls from "strace.h".  I'd be happy for this to go into HEAD;
it's not a functionality patch, more of a brisk clean-up and
rub-down patch :-)

// Conrad

nb. The patch includes a new file "src/winsup/cygwin/woutsup.h"
that I've attached separately.

Attachment: ChangeLog.txt
Description: Text document

Attachment: cygwin_daemon.patch.bz2
Description: Binary data

Attachment: woutsup.h
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]