This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pthread_fork Part 3


On Sat, 2002-08-17 at 06:55, Thomas Pfaff wrote:
> 
> Pthread key destructor handling revised. IMHO it does not make sense to
> handle two lists with keys, one with all keys, one with its destructors.
> The destructors are now part of the key class.

I agree with the duplication of code. This is one area I'd really really
really like to use templates. 

Chris, Corinna, if we ever get the chance to use templates please tell
me so! It makes code clarity and size so much better.

Anyway, yes, we should only have one list. So yes, please do refactor
the two together in the way I've arranged the pthread_keys::keys list.

Note that you have a comment on non thread safeness in the new
pthread_keys code. I thought I had addressed that in my list code, could
you either tell me I was also not thread safe, or correct that at the
same time?

Cheers,
Rob

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]