Re: [PATCH] fix segv in pthread_mutex::init

[Robert Collins <rbcollins at cygwin dot com>]

On Thu, 2002-10-17 at 18:11, Thomas Pfaff wrote:
> 
> This patch should fix the segfault in pthread_mutex::init by changing the
> test order for a valid object and checking for valid initializer object
> first..

I'm happy with the verifyable_object change. I'm not happy with the
pthread_mutex::init change (yet).

I've checked in the verifyable_object stuff, along with a
pthread_mutex::init change I am happy with.

The reason I wasn't happy with your change was threefold:
1) there is no need to add scoping to static calls within a class. Doing
so reduces readability, and should be avoided.
2) The test was no longer *obvious* at first read, whereas (IMO) what
I've checked in is.

Cheers,
Rob

-- 
---
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
---

Attachment: signature.asc
Description: This is a digitally signed message part