This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
FIXED Re: [PATCH] fhandler_tty deadlock patch
- From: Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
- To: cygwin-patches at cygwin dot com
- Cc: Steve O <bub at io dot com>
- Date: Mon, 21 Oct 2002 14:51:15 -0400 (EDT)
- Subject: FIXED Re: [PATCH] fhandler_tty deadlock patch
- Reply-to: cygwin-patches at cygwin dot com
On Mon, 21 Oct 2002, Igor Pechtchanski wrote:
> On Mon, 21 Oct 2002, Steve O wrote:
>
> > On Sun, Oct 20, 2002 at 11:15:47PM -0400, Igor Pechtchanski wrote:
> > > However, there are a couple of problems with this patch. For example,
> > > this makes bash run from a command prompt (or a shortcut) treat every
> > > character as a ^D.
> >
> > So every character closes bash? I'm not able to reproduce this on
> > WinXP, have an strace?
>
> Sure. I'm attaching an strace for 'bash --rcfile /dev/null'; the
> character pressed was a space. This affects most programs, btw (vi from a
> command prompt, for example, and tcsh), but not sh, cat or less. My guess
> is that anything that uses readline is affected. I'm running Win2k SP2,
> if it makes any difference.
Well, rebuilding cygwin1.dll from scratch seems to have solved this
problem, which probably indicates that some dependence is not computed
correctly. So, Steve's patch works for me, sorry for the false alarm.
> > > /bin/sh ignores Enter (or ^J, or ^M).
> >
> > Good find. I've attached a diff that should fix this. Unsure
> > how to proceed since the original patch hasn't been applied.
> > Do I resubmit the original patch or treat this one as it's own
> > thing?
>
> Thanks, I'll try it out and let you know if it works for me.
This also works.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51