This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ntsec odds and ends


> On Thu, 6 Feb 2003, Corinna Vinschen wrote:
>>> -      char group_name [UNLEN + 1] = "mkgroup";
>>> +      char group_name [UNLEN + 1] = "run mkgroup";
>>
>> I didn't commit this change.
>>
>>> +      if (myself->uid == UNKNOWN_UID)
>>> + strcpy (group_name, "run mkpasswd"); /* Feedback... */
>>
>> I've changed that to just "mkpasswd".
>>
>> I don't like to introduce group names with spaces in it.  And since
>> they are longer than 8 chars, they'd get truncated by ls anyway.

Having a space in the names makes it much more obvious that something odd is
happening. And these names should never be allowed to persist for long.

Perhaps you would consider some punctuation in the names instead?
e.g.: <mkpasswd> <mkgroup>

Truncation by ls shouldn't matter much. I would say that a new user is more
likely to notice "run mkpa" than "mkpasswd".



Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]