This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: A patch for the cygwin1.dll console handler


Because I do the changes at home for my hobby , I will probably send
this patch to red-hat aproval system this week-end. So for your
question, Actually, the cygwin terminal have: esc  [ D for normal shift
et ctrl, esc esc  [ D for alt. I can change this to the xterm
conformences. If you have a spec for this no problems. If you think that
my patch has no interrest a priori let me know. 

Thank you for your suggestions.


Daniel


-----Message d'origine-----
De : Corinna Vinschen [mailto:cygwin-patches at cygwin dot com]
Envoye : mardi 11 mars 2003 09:57
A : COTTO Daniel FTRD/DMI/CAE
Cc : cygwin-patches at cygwin dot com
Objet : Re: A patch for the cygwin1.dll console handler


On Tue, Mar 11, 2003 at 08:02:58AM +0100, COTTO Daniel FTRD/DMI/CAE
wrote:
> Hello,
> 
> I have made a patch to the cygwin1.dll .
> Its main purpose is to allow a nul character to be input from a french
keyboard. Also this patch adds some othre functions keys. If you are
interrested you have the diff -up file from the last cvs 03/03/2003
05:00  fhandler_console.cc
> 
> the binding added are:
> * ctrl-spc: nul character
> * ctrl-f1 through ctrl-f10: \e7~ through \e16~
> * alt-f1 through alt f10: \e[38~ through \e[47~
> * app key binded to: \e[50~
> * ctrl-tab and alt tab bind to esc tab. 
> * and some other minor binding; (see the attachment).
> 
> If you want, you can use this patch and you can add it to a next
version of cygwin1.dll.

That's not how it works unfortunately.  The size of the patch is too big
to go through as insignificant. 

Have another look on http://cygwin.com/contrib.html, please.  You'll
have to sign an assignment form and send it to Red Hat.  As soon as
the assignment form arrived, we can review and eventually incorporate
your patch.  However, you should als add a ChangeLog entry as described
on that page.

A question:  How much sense does it make to change the key bindings
of the cursor block so that Normal/Shift and Ctrl/Alt return the same
code?  Looking into the keycodes returned by an xterm, it returns
for instance on VK_LEFT:

  Normal:  ESC [ D
  Shift:   ESC [ 2 D
  Ctrl:    ESC [ 5 D
  Alt:     ESC ESC [ D

4 different key codes.  Wouldn't it make sense to do the same here?

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin at cygwin dot com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]