This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] performance patch for /proc/registry -- version 2
On Wed, Mar 26, 2003 at 02:48:33PM -0500, Joe Buehler wrote:
> Chris January wrote:
>
> >How common are ACLs > 4096 bytes? Could you try calling RegKeyGetSecurity
> >twice? First with a length of 0. Then RegKeyGetSecurity will set length to
> >the required buffer size which you can allocate dynamically using new.
>
> Whatever Corinna or Christopher want me to do is fine with me. I just
> copied some code from elsewhere in Cygwin.
It's ok to use the 4K for now. I'm sure there are more dangerous places
in the code where we're currently using a 4K buffer for SDs or ACLs as well.
However... am I doing something wrong? I'm trying to find out what the
performance improvement is on my XP box and both versions of the DLL
(w/ and w/o your patch) are running 7.5 minutes for
ls -lR /proc/registry > /dev/null
Or is that only a problem on older systems? You're running NT4SP5, right?
Other than that your patch looks fine.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin at cygwin dot com
Red Hat, Inc.