This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: {Patch]: Giving access to pinfo after seteuid and exec


On Fri, Sep 26, 2003 at 09:41:17AM -0400, Pierre A. Humblet wrote:
> Corinna Vinschen wrote:
> > Somehow I'm missing a description why that's necessary and the
> > implications.
> > 
> I am getting paranoid. Most often we duplicate DUPLICATE_SAME_ACCESS
> without thinking about what access is really needed. It would be a good
> discipline to ask ourselves what is needed and give just that. Here nothing
> is needed at all. 
> Also, if you use sysinternals you can see the access mask. Setting it
> properly creates differentiating features that help distinguish between
> all the handles.

This handle is only used to have a handle.  It's never accessed, just
kept so that we not get the same Winpid again, right?  If so, the
patch is ok, of course.  I was just missing a description.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]