This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Create Global Privilege


At 09:47 PM 11/25/2003 -0500, you wrote:
>On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote:
>>Other than that minor point, this looks ok.
>
>Sorry.  On rereading this this sounded rather lukewarm.  I'm very happy
>that you are fixing this problem.  I should probably let Corinna have
>the final word on this, though.
>
>Thanks.

OK, I will be out of town for a few days, so it would be nice if Corinna 
could apply it as well.

Regarding your remark, I had thought of putting prefix on the cygheap,
but that looked like overkill (could be done some day, together with 
cygwin_user_h and a few others).

With a few exceptions (e.g. utmp/wtmp handling in login/logout), shared_name
is only called when the map handle is NULL, e.g. when starting cygwin 
(thus relatively rarely).
It's also called for the title_mutex, but that's only needed for old systems 
that don't have GetConsoleWindow, so a better optimization would be to only
call it when needed. That mutex is a great DOS source. Fixing that is on
my todo list, as a side effect of more important stuff.

Pierre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]